Use implicit join to create Predicate if possible#3374
Closed
quaff wants to merge 1 commit intospring-projects:mainfrom
Closed
Use implicit join to create Predicate if possible#3374quaff wants to merge 1 commit intospring-projects:mainfrom
quaff wants to merge 1 commit intospring-projects:mainfrom
Conversation
Contributor
Author
Member
|
Thank you @quaff! Would you mind adding some tests to verify the behaviour? |
Contributor
Author
I'm trying. |
Contributor
Author
@christophstrobl Done! |
Contributor
Author
Contributor
Author
|
There is a subtle change by this PR, since implicit join will use inner join, then |
5 tasks
52ee55f to
61e6d36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix GH-3349